Support all transaction types in Relayer#907
Draft
shermike wants to merge 1 commit intorelayer-and-pure-tokensfrom
Draft
Support all transaction types in Relayer#907shermike wants to merge 1 commit intorelayer-and-pure-tokensfrom
shermike wants to merge 1 commit intorelayer-and-pure-tokensfrom
Conversation
isergeyam
reviewed
May 16, 2025
| */ | ||
| function calculateGasForTargetCall(bool request) internal view returns(uint) { | ||
| uint gasForResponse = 50_000; | ||
| uint requiredGasForFinish = 50_000; |
Contributor
There was a problem hiding this comment.
I think we should add a comment here explainig that requiredGasForFinish is actually for finishing receiveTx, otherwise it's not very clear
olegrok
reviewed
May 19, 2025
| } else { | ||
| bt.Printf("data_size: %d\n", len(txn.Data)) | ||
| if len(txn.Data) < 1024 { | ||
| bt.Printf("data: %s\n", hexutil.Encode(txn.Data)) |
Contributor
There was a problem hiding this comment.
Suggested change
| bt.Printf("data: %s\n", hexutil.Encode(txn.Data)) | |
| bt.Printf("data: %s\n", hexutil.Bytes(txn.Data)) |
Or even
Suggested change
| bt.Printf("data: %s\n", hexutil.Encode(txn.Data)) | |
| bt.Printf("data: %x\n", txn.Data) |
Comment on lines
+25
to
+27
| func (dp DeployPayload) BytesWithoutSalt() []byte { | ||
| return dp.bytes[:len(dp.bytes)-common.HashSize] | ||
| } |
Contributor
There was a problem hiding this comment.
Isn't Code() enough?
BytesWithoutSalt is even longer than Code().Bytes()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncmodifier for functions that initiate cross-shard transactions. It is required to enable gas forwarding.Nil.CreateAddressinternally usesNil.CreateAddressForCreate2, with the Relayer address as the sender.NilBase.nilReceive()method to allow receiving funds even if the contract lacks areceive()function.